Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: run sqlness test in distributed mode #916

Merged
merged 7 commits into from
Jan 31, 2023
Merged

test: run sqlness test in distributed mode #916

merged 7 commits into from
Jan 31, 2023

Conversation

e1ijah1
Copy link
Contributor

@e1ijah1 e1ijah1 commented Jan 29, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • run sqlness test in distributed mode
  • update ci

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Jan 29, 2023 •
edited
Loading

Codecov Report

Merging #916 (a6bc321) into develop (dc9b533) will decrease coverage by 0.23%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #916      +/-   ##
===========================================
- Coverage    86.25%   86.03%   -0.23%     
===========================================
  Files          430      434       +4     
  Lines        57928    58342     +414     
===========================================
+ Hits         49968    50192     +224     
- Misses        7960     8150     +190
Flag Coverage Δ
rust 86.03% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/object-store/src/test_util.rs 0.00% <0.00%> (-100.00%) ⬇️
tests-integration/src/test_util.rs 79.18% <0.00%> (-20.36%) ⬇️
src/datanode/src/instance.rs 47.11% <0.00%> (-18.44%) ⬇️
src/servers/src/postgres/handler.rs 83.21% <0.00%> (-7.46%) ⬇️
src/servers/src/postgres/auth_handler.rs 88.48% <0.00%> (-1.46%) ⬇️
src/datanode/src/datanode.rs 57.62% <0.00%> (-1.31%) ⬇️
src/cmd/src/datanode.rs 76.97% <0.00%> (-0.51%) ⬇️
src/frontend/src/error.rs 11.76% <0.00%> (-0.24%) ⬇️
src/servers/src/postgres/server.rs 96.92% <0.00%> (-0.10%) ⬇️
src/common/procedure/src/lib.rs 100.00% <0.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

MichaelScofield
MichaelScofield reviewed Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@MichaelScofield MichaelScofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me, thx @e1ijah1 ! However, the sqlness test action is failed, can you take a look?

tests/runner/src/env.rs Outdated Show resolved Hide resolved
@e1ijah1
Copy link
Contributor Author

e1ijah1 commented Jan 30, 2023

This is looking good to me, thx @e1ijah1 ! However, the sqlness test action is failed, can you take a look?

It looks like the datanode process failed to start. I tested it in both Linux and Mac environments but couldn't reproduce the issue. Could you please take a look at /tmp/greptime-sqlness-datanode.log?

@MichaelScofield
Copy link
Collaborator

@e1ijah1 Seems that log cannot be downloaded? Can you cat that log (and other related logs) in the sqlness post-run action so we can directly see them in the action stdout?

@waynexia
Copy link
Member

@e1ijah1 Seems that log cannot be downloaded? Can you cat that log (and other related logs) in the sqlness post-run action so we can directly see them in the action stdout?

I'll upload the logs as CI artifacts, give me a minute

@waynexia waynexia mentioned this pull request Jan 31, 2023
Merged
2 tasks
@e1ijah1
Copy link
Contributor Author

e1ijah1 commented Jan 31, 2023

@waynexia @MichaelScofield

My bad. Sqlness Job doesn't start etcd, causing the issue. The problem has been resolved.

@waynexia
Copy link
Member

There are some conflicts with #920

The problem has been resolved.

👍

@e1ijah1
Copy link
Contributor Author

e1ijah1 commented Jan 31, 2023

There are some conflicts with #920

The problem has been resolved.

👍

fixed, PTAL

waynexia
waynexia approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, appreciate it @e1ijah1 ❤️

@MichaelScofield MichaelScofield merged commit 9a30ba0 into GreptimeTeam:develop Jan 31, 2023
@MichaelScofield MichaelScofield mentioned this pull request Jan 31, 2023
Closed
paomian pushed a commit to paomian/greptimedb that referenced this pull request Oct 19, 2023
@e1ijah1 @paomian
test: run sqlness test in distributed mode (GreptimeTeam#916)
ace9a0b 
* test: run sqlness test in distributed mode

* chore: fix ci test

* chore: improve the ci yaml

* chore: improve the code

* chore: fix conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@e1ijah1 @MichaelScofield @waynexia